Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Add test case for nvbug 4678853 #2045

Open
1 task done
wmaxey opened this issue Jul 24, 2024 · 2 comments
Open
1 task done

[BUG]: Add test case for nvbug 4678853 #2045

wmaxey opened this issue Jul 24, 2024 · 2 comments
Labels
bug Something isn't working right.

Comments

@wmaxey
Copy link
Member

wmaxey commented Jul 24, 2024

Is this a duplicate?

Type of Bug

Compile-time Error

Component

CUB

Describe the bug

Multiple definition error from 4678853 needs a reproducer added to our test suite. This should be as simple as linking together a pair of each header. We should probably try to do this in every project if not already done.

How to Reproduce

create bar.cc
#include <thrust/complex.h>

create foo.cc
#include <thrust/complex.h>
build:
g++ -c -fPIC -I /usr/local/cuda/include bar.cc
g++ -c -fPIC -I /usr/local/cuda/include foo.cc
g++ -fPIC bar.o foo.o -shared -Wl,-soname,libhello.so -o libhello.so

Expected behavior

We shouldn't emit multiple definition errors by leaking non-static interfaces into the TU.

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response

@wmaxey wmaxey added the bug Something isn't working right. label Jul 24, 2024
@miscco
Copy link
Collaborator

miscco commented Jul 24, 2024

I believe we should do that in the context of our all public headers test set.

We already have all public headers there and it should be simple to create two TUs that include all those headers and link two.

@wmaxey
Copy link
Member Author

wmaxey commented Jul 24, 2024

We already have all public headers there and it should be simple to create two TUs that include all those headers and link two.

Exactly. We just need to flex that we can link all the permutations of NVCC + compiler.

e.g.
NVCC+NVCC
GCC+NVCC
GCC+GCC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right.
Projects
Status: Todo
Development

No branches or pull requests

2 participants