Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUB nvbench-based benchmarks should not sync #2087

Open
bernhardmgruber opened this issue Jul 26, 2024 · 0 comments
Open

CUB nvbench-based benchmarks should not sync #2087

bernhardmgruber opened this issue Jul 26, 2024 · 0 comments
Assignees
@gevtushenko
Labels
cub For all items related to CUB

Comments

@bernhardmgruber
Copy link
Contributor

@gevtushenko explaint to me that CUB's benchmark should not use the nvbench::exec_tag::sync tag type when executing a benchmark region. However, this is used in two CUB benchmarks segmented_sort/keys.cu and copy/memcpy.cu. Let's verify those uses and if they are justified, add a comment explaining why the sync is needed.

Thrust benchmarks need the sync flag.
@bernhardmgruber bernhardmgruber added the cub For all items related to CUB label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gevtushenko gevtushenko

Labels
cub For all items related to CUB
Projects
CCCL
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bernhardmgruber @gevtushenko