Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-multiple of 4 workloads in reproducible reduction #2112

Closed
Tracked by #1558
gevtushenko opened this issue Jul 30, 2024 · 1 comment
Closed
Tracked by #1558

Support non-multiple of 4 workloads in reproducible reduction #2112

gevtushenko opened this issue Jul 30, 2024 · 1 comment
Assignees

Comments

@gevtushenko
Copy link
Collaborator

gevtushenko commented Jul 30, 2024

As we kept simplifying the reproducible reduction kernel, we removed the code path that processes incomplete tiles. This makes current code return incorrect results on inputs which size is not multiple of four (vector size).

This issue can be closed by:

  • passed test case that runs reproducible reduction of odd number of elements
  • NVBench result illustrating that this chance hasn't introduced performance regressions
@SAtacker
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants