Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-contiguous iterators in reproducible reductions #2122

Open
Tracked by #1558
gevtushenko opened this issue Jul 31, 2024 · 0 comments
Open
Tracked by #1558

Handle non-contiguous iterators in reproducible reductions #2122

gevtushenko opened this issue Jul 31, 2024 · 0 comments
Assignees

Comments

@gevtushenko
Copy link
Collaborator

gevtushenko commented Jul 31, 2024

As we kept simplifying the reproducible reduction kernel, we removed the code path responsible for handling non-contiguous iterators. Reproducible reduction should correctly handle fancy iterators.

This issue can be closed by:

  1. Passing test case of reproducible reduction on thrust::transform_iterator or thrust::constant_iterator
  2. NVBench result illustrating that this change doesn't regress performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants