[BUG]: Remove warning suppressions from Thrust build system. #2409
Labels
bug
Something isn't working right.
Comments
alliepiper
added a commit
to alliepiper/cccl
that referenced
this issue
Sep 11, 2024
There are hundreds of these, and most of them appear to be in the unit tests, not the actual Thrust headers. It's turning into a rabbit hole and dragging beyond the scope of the current PR. Filed NVIDIA#2409 to track the removal of these suppressions.
alliepiper
added
good first issue
alliepiper
added a commit
that referenced
this issue
Sep 12, 2024
* Share common compiler flags in new CCCL-level targets. * fix up some warnings from cudax/ * Avoid deprecation warning from allocator_traits * Silence conversion warning in tuple_leaf * Suppress conversion warning in complex test * Fix more conversion warnings * Silence warning about signedness of unary minus * Let doxygen ignore warning suppression * Suppress a variety of warnings on MSVC. * Fix unused parameter warning. * Suppress reordering warnings on ICC, too. * More msvc taming. * More warnings. * More MSVC narrowing warning fixes. * Re-enable global suppression of MSVC warnings. There are hundreds of these, and most of them appear to be in the unit tests, not the actual Thrust headers. It's turning into a rabbit hole and dragging beyond the scope of the current PR. Filed #2409 to track the removal of these suppressions. --------- Co-authored-by: Eric Niebler <[email protected]> Co-authored-by: Michael Schellenberger Costa <[email protected]>
alliepiper
added a commit
to alliepiper/cccl
that referenced
this issue
Sep 13, 2024
* Share common compiler flags in new CCCL-level targets. * fix up some warnings from cudax/ * Avoid deprecation warning from allocator_traits * Silence conversion warning in tuple_leaf * Suppress conversion warning in complex test * Fix more conversion warnings * Silence warning about signedness of unary minus * Let doxygen ignore warning suppression * Suppress a variety of warnings on MSVC. * Fix unused parameter warning. * Suppress reordering warnings on ICC, too. * More msvc taming. * More warnings. * More MSVC narrowing warning fixes. * Re-enable global suppression of MSVC warnings. There are hundreds of these, and most of them appear to be in the unit tests, not the actual Thrust headers. It's turning into a rabbit hole and dragging beyond the scope of the current PR. Filed NVIDIA#2409 to track the removal of these suppressions. --------- Co-authored-by: Eric Niebler <[email protected]> Co-authored-by: Michael Schellenberger Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a duplicate?
Type of Bug
Something else
Component
Thrust
Describe the bug
Thrust's build system has suppressed these MSVC warnings:
The warnings are suppressed in this file.
These should be removed and the warnings either fixed or suppressed locally with the
_CCCL_DIAG_*macros.How to Reproduce
Remove the warning suppressions from the above linked file and build the Thrust project on MSVC.
Expected behavior
The thrust developer build should compile without globally suppressing these warnings.
Reproduction link
No response
Operating System
No response
nvidia-smi output
No response
NVCC version
No response
The text was updated successfully, but these errors were encountered: