Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Project automations not setting to draft on changes requested #408

Closed
1 task done
jarmak-nv opened this issue Sep 6, 2023 · 0 comments · Fixed by #387
Closed
1 task done

[BUG]: Project automations not setting to draft on changes requested #408

jarmak-nv opened this issue Sep 6, 2023 · 0 comments · Fixed by #387
Assignees
@jarmak-nv
Labels
bug Something isn't working right.

Comments

@jarmak-nv
Copy link
Collaborator

Is this a duplicate?

Type of Bug

Something else

Component

Not sure

Describe the bug

When requesting changes, the intention of the project automations is that we set the PR back to draft to show it's still in progress. This isn't happening right now.

How to Reproduce

See this PR:

  • Changes are requested, but it doesn't flip to draft

It's a simple logic error in this line:
https://github.com/NVIDIA/cccl/blob/main/.github/workflows/project_automation_set_in_progress.yml#L61

We can see in the workflow the logic failure:
https://github.com/NVIDIA/cccl/actions/runs/6097537975/job/16545369841#step:2:8

elif [ false == true ]; then is how it evaluates because it's not a draft.

Expected behavior

It should be a draft!

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response
@jarmak-nv jarmak-nv added the bug Something isn't working right. label Sep 6, 2023
@jarmak-nv jarmak-nv self-assigned this Sep 6, 2023
jarmak-nv added a commit to jarmak-nv/cccl that referenced this issue Sep 6, 2023
@jarmak-nv
[skip ci] fixing NVIDIA#408
48b8b59
jarmak-nv added a commit to jarmak-nv/cccl that referenced this issue Sep 6, 2023
@jarmak-nv
[skip ci] Undoing fix for NVIDIA#408, moving it to NVIDIA#387
7ce9383
jarmak-nv added a commit to jarmak-nv/cccl that referenced this issue Sep 6, 2023
@jarmak-nv
[skip ci] Fixing NVIDIA#408
c771b4d
This was referenced Sep 6, 2023
Merged
Merged
jrhemstad pushed a commit that referenced this issue Sep 7, 2023
@jarmak-nv
Project Automation: Handle PRs opened as non-draft + multiple bug fix…
ac161d7 
…es (#387)

* Set PR/Issue to Review if it's opened as non-draft

* Add continue-on-error to the new step

* [skip ci] Fix logic for setting `STATUS_OPTION_ID`

* [skip ci] Fixing #408

* Correct json reference for status jq
jrhemstad pushed a commit that referenced this issue Sep 7, 2023
@jarmak-nv
Project Automation: set Roadmap project value on issue/pr close and…
c7eb05d 
… Auto-type new issues (#389)

* Create action to set roadmap on close

* Update job name to be more descriptive

* [skip ci] fixing #408

* [skip ci] Undoing fix for #408, moving it to #387

* [skip ci] Add action to autoset issue type on open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarmak-nv jarmak-nv

Labels
bug Something isn't working right.
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Project Automation: Handle PRs opened as non-draft + multiple bug fixes jarmak-nv/cccl
1 participant
@jarmak-nv