Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keccak should compute over non-contiuous memory regions #127

Open
Scooletz opened this issue Aug 17, 2023 · 1 comment
Open

Keccak should compute over non-contiuous memory regions #127

Scooletz opened this issue Aug 17, 2023 · 1 comment
Labels
🐌 performance Perofrmance related issue

Comments

@Scooletz
Copy link
Contributor

Scooletz commented Aug 17, 2023

Paprika has a copy of Keccak from Nethermind Keccak. Currently, Keccak implementation does not implement HashAlgorithm. The mentioned class provides two methods

  1. HashCore(ReadOnlySpan) and
  2. HashFinal()
    that can be used to construct a hash over a non-continuous memory. It'd be great if Keccak, even without implementing the actual HashAlgorithm allowed for handling the upgradability and consumption of sequences of memory.

Once provided, RLP encoding could benefit from it greatly.

Be minded, that it does not have to use ReadOnlySequence<byte> per se, but might provide some other, streaming API that could for example accept up to N spans by providing a span-like sequence or multiple overloads.

@Scooletz Scooletz added good first issue Good for newcomers 🐌 performance Perofrmance related issue and removed good first issue Good for newcomers labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐌 performance Perofrmance related issue
Projects
Status: Backlog
Development

No branches or pull requests

1 participant