Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encounter potential bug while using get events with complex filter #1922

Open
NikitaMishin opened this issue Jul 2, 2024 · 0 comments
Open

Comments

@NikitaMishin
Copy link

NikitaMishin commented Jul 2, 2024

Using https://free-rpc.nethermind.io/sepolia-juno endpoint

Encountered issue that if i query event and filter by complex component key node will fire for me events that not satisfy filter.
I didn't manage to reproduce this behaviour over https://starknet-sepolia.public.blastapi.io/rpc/v0_7 so i presume the issue might be in node. Maybe once it finds block with satisfied events it just iterate over superset in this block not honouring original filter

Steps to reproduce:
https://sepolia.starkscan.co/tx/0x564f7fb5078f2f1ff708fbf41828d5f46d4494c2cde08274dc3aa32d65b0aca (we are interested in this block)

Filter (for indexed filed called taker)

    [
      [
        '0x22ea134d4126804c60797e633195f8c9aa5fd6d1567e299f4961d0e96f373ee'
      ],
      [
        '0x2e0a012a863e6b614014d113e7285b06e30d2999e42e6e03ba2ef6158b0a8f1'
      ],
      [],
      [
        '0x03765D53fdd82921fDDc888c04072fb618E6AC40eCAbc83084df6848a037a079'
      ]
    ]

Example of the event (https://sepolia.voyager.online/event/77850_310_10)

If i query, then it would additional add to response events, emitted in this https://sepolia.starkscan.co/tx/0x564f7fb5078f2f1ff708fbf41828d5f46d4494c2cde08274dc3aa32d65b0aca transaction where taker of events is 0x059f71591a53fe7e7614292f36a6688e5290e1f73ad59be58c64b61c39aac23f while we are filtering by
0x03765D53fdd82921fDDc888c04072fb618E6AC40eCAbc83084df6848a037a079

NikitaMishin added a commit to LayerAkira/akira-js that referenced this issue Jul 4, 2024
1) fix issue related to NethermindEth/juno#1922
2) reflect changes in API (reducing of data transmitted between client and server)
3) support cancel all on exchange ticker
4) utils to cast back and forth from string to bigint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant