Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P: handle StateDiffsResponse_DeclaredClass #2031

Open
kirugan opened this issue Aug 7, 2024 · 1 comment
Open

P2P: handle StateDiffsResponse_DeclaredClass #2031

kirugan opened this issue Aug 7, 2024 · 1 comment
Assignees
@AnkushinDaniil

Comments

@kirugan
Copy link
Contributor

kirugan commented Aug 7, 2024

We don't handle *spec.StateDiffsResponse_DeclaredClass messages right now. See p2p/sync.go:514
@AnkushinDaniil AnkushinDaniil self-assigned this Aug 7, 2024
@AnkushinDaniil
Copy link
Contributor

The StateDiffsResponse_DeclaredClass message is necessary because it provides a more secure and reliable way to retrieve class hashes, especially for Cairo 0 classes, where verification without state diffs is impossible. After the spec update it's possible to validate the class hash before downloading large amounts of information. It's still unclear how to use declaredClass in stateDiffResponse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnkushinDaniil AnkushinDaniil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kirugan @AnkushinDaniil