New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit go routines #1

Open

mguentner opened this issue Nov 8, 2017 · 0 comments

Member

mguentner commented Nov 8, 2017

https://github.com/NixIPFS/create-nixipfs-go/blob/master/create_nixipfs.go#L75

Opens too many files at once. Limit this by using a buffered chan, like so:

        maxAddRoutines := 10
        if err != nil {
                log.Fatal(err)
        }
        c0 := make(chan struct{}, maxAddRoutines)
        for _, f := range files {
                c0 <- struct{}{}
                go func(f string) {
                        AddToIPFS(sh, f)
                        <-c0
                }(f)
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment