Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to avoid type erasure in trait Logger #602

Open
Wodann opened this issue Aug 16, 2024 · 0 comments
Open

Try to avoid type erasure in trait Logger #602

Wodann opened this issue Aug 16, 2024 · 0 comments

Comments

@Wodann
Copy link
Member

Wodann commented Aug 16, 2024

To decouple the error returned from the trait Logger from the Provider, we converted the error type to a Box<dyn std::error::Error>.

This change was made because it introduced a LoggerErrorT generic on the ProviderData which was bleeding into other traits/types.

Ideally, we'd avoid type erasure in error management. Since the original change, some refactors have happened that might make it possible to reintroduce the strongly typed Error.

Definition of Done
Either

  • reintroduce the type Error on the trait Logger in an extensible way; or
  • determine that it's impossible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant