Use Alchemy URL from environment

[agostbiro]

Problem

There still some hard-coded Alchemy credentials in the Solidity tests codebase (especially in .sol test files). This is a problem, because these publicly available keys are less reliable than per-user, potentially higher throughput keys. It's not high prio to fix it though as the RPC calls they're used for are heavily cached and we haven't seen any timeouts yet.

Definition of Done

When searching for g.alchemy.com or alchemyapi.io, there are no hard-coded credentials.

[KoxyG]

Kindly assign me to this @agostbiro

[agostbiro]

Hi @KoxyG thanks for volunteering to take care of this issue! I've assigned you now. Please fork from the feat/solidity-tests branch and have your PR target this branch.

[agostbiro]

Btw, out of curiosity, how did you find this issue?

[KoxyG]

Thanks. I found it here. https://onchainsquad.com/oss/

[KoxyG]

I am done cloning from the "feat/solidity-tests" branch. What folder am i meant to work on?, is it the "hardhat-tests/test" folder? @agostbiro

[agostbiro]

@KoxyG the relevant files are int crates/foundry directory