Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotNet bot-conversation-sso-quickstart breaks DI #1336

Open
tracyboehrer opened this issue Jul 22, 2024 · 3 comments
Open

DotNet bot-conversation-sso-quickstart breaks DI #1336

tracyboehrer opened this issue Jul 22, 2024 · 3 comments

Comments

@tracyboehrer
Copy link

samples/bot-conversation-sso-quickstart

The AdapterWithErrorHandler in this project does not accept the BotFrameworkAuthentication that was added via DI in Program.cs. This result in a new ConfigurationBotFrameworkAuthentication being constructed manually, ignoring what was setup in DI.

The AdapeterWithErrorHandler constructor should look like:

        public AdapterWithErrorHandler(
            BotFrameworkAuthentication auth,
            IConfiguration configuration,
            IHttpClientFactory httpClientFactory,
            ILogger<IBotFrameworkHttpAdapter> logger,
            IStorage storage,
            ConversationState conversationState)
            : base(auth, logger)
        {
            ...
        }

 

Hi @tracyboehrer! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

@sayali-MSFT
Copy link

@tracyboehrer -Thanks for reporting your issue.
We will check this at our end and will get back to you.

@sayali-MSFT
Copy link

We are able to repro that issue, we are checking it internally and let you know once we get any updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants