Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add labels to help organize images by project #6

Open
mwalzer opened this issue Oct 23, 2017 · 4 comments
Open

add labels to help organize images by project #6

mwalzer opened this issue Oct 23, 2017 · 4 comments
Assignees

Comments

@mwalzer
Copy link

mwalzer commented Oct 23, 2017

because best practices and to be courteous to BioContainers project

@mwalzer mwalzer self-assigned this Oct 23, 2017
@jpfeuffer
Copy link
Contributor

Should we then also base all images on the biocontainers image?
Or create a separate one?

@hroest
Copy link
Contributor

hroest commented Oct 23, 2017

i think that is a good idea for compatibility but we may also want to have a minimal image for people that want to have as little overhead as possible

@mwalzer
Copy link
Author

mwalzer commented Oct 24, 2017

The labels are best practice for any project, but they are loosely defined metadata to the image instructions. I think it will do us no harm adopting the more palpable definitions the bio containers team are proposing even if we don't base on bio containers image. But I agree with @hroest we should go for a minimal image for ourselves first

@mwalzer
Copy link
Author

mwalzer commented Oct 24, 2017

but in any case, with multistage docker builds, that should be fairly managable. I'm very happy with that new docker development (since v17.05) 😃
update:
Just talked to Yasset, seems that they are changing that in the specifications for biocontainers, so other bases can be used.

mwalzer added a commit to mwalzer/dockerfiles that referenced this issue Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants