Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable repeat when playing an entire album/artist #847

Open
4 tasks done
Martysh12 opened this issue Aug 3, 2024 · 11 comments
Open
4 tasks done

Disable repeat when playing an entire album/artist #847

Martysh12 opened this issue Aug 3, 2024 · 11 comments
Assignees
Labels
enhancement New feature or request playback Related to music playback

Comments

@Martysh12
Copy link
Contributor

Description

Disable repeat when pressing the "play" button on the album/artist screen.

Problem solved

Whenever I press the "play" button, I intend to play the entirety of the album/artist, not just the first track over and over again (for that I'd simply select the first track). Currently, pressing "play" doesn't disable repeat:

recording_20240803_182239.mp4

This issue creates some funny situations where I press the "play" button, put my phone away, cover my hands in cooking oil, and realise that I'm stuck on the first track of the album without being able to do anything.

Other implementations

Gramophone seems to disable repeat when pressing the play icon on an artist/album.

Benefit

It just makes more sense to have the "play" button play the entire album, instead of keeping the repeat state.

Duplicates

@Martysh12 Martysh12 added the enhancement New feature or request label Aug 3, 2024
@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Aug 6, 2024

This sounds like a good companion setting in the same vein as 'Remember Shuffle'. Will spec it out.

@OxygenCobalt OxygenCobalt added the playback Related to music playback label Aug 12, 2024
@OxygenCobalt
Copy link
Owner

So, I can spec this in three ways @Martysh12:

  • Spec it exactly like you want, making the behavior to drop the repeat mode between playing from distinct sources. This is inconsistent with remember shuffle though.
  • Spec it more broadly, making the behavior to drop the repeat mode when playing any new song (even from the same source, i.e if you're browsing around an artist).
  • Make both Remember Shuffle and Remember Repeat both a type of dropdown with the prior options available at once (On, When playing from the same source, Never). This is really hard to explain coherently though.

@Martysh12
Copy link
Contributor Author

@OxygenCobalt Could you elaborate on the 1st and the 3rd options please? What's a distinct source?

@OxygenCobalt
Copy link
Owner

A distinct source is like playing from an Album vs. an Artist. So if I went with Option 1, the repeat mode would only clear when switching playback to an Artist from an Album, rather than when playing a new song within the album @Martysh12.

It's hard to explain, hence why I am hesitant. I would rather do Option 2 since it's much easier to explain to users.

@Martysh12
Copy link
Contributor Author

Martysh12 commented Sep 8, 2024

Option 2 sounds like it would clear Repeat One whenever I switch to a new track, so I'm not quite sure about it. Option 1 makes more sense to me.
To elaborate, I usually Repeat One a track, then switch to a new one when I get bored. Option 2 sounds like it would clear the repeat mode, so it'll be a bit annoying to enable Repeat One every time I switch to a new track.

@OxygenCobalt
Copy link
Owner

Yeah, that's what I want, but I can't figure out how to explain it clearly @Martysh12.

@Martysh12
Copy link
Contributor Author

Martysh12 commented Sep 9, 2024

Hmm, maybe have a label next to the option with something like
"Disable repeat when switching to a different album/artist/genre"?

@OxygenCobalt

@Martysh12
Copy link
Contributor Author

Actually, I really like the idea of having a dropdown and being able to choose when repeat clears. So the third option, maybe?

@OxygenCobalt
Copy link
Owner

That would make explanation even harder UI-wise @Martysh12

@Martysh12
Copy link
Contributor Author

image

Here, @OxygenCobalt, I made a mockup of the "clear repeat" option in settings.
Tbh, I think it makes a lot of sense UX-wise.

@OxygenCobalt
Copy link
Owner

Okay, this makes sense @Martysh12. For consistency, I might go and invert Remember shuffle (and remember pause) in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request playback Related to music playback
Projects
Status: Playback Refinement Update
Development

No branches or pull requests

2 participants