From 8573c7f4b26a33890b501bd55df38484c4595e7c Mon Sep 17 00:00:00 2001 From: Fabian Boettcher Date: Tue, 4 Feb 2020 16:28:26 +0100 Subject: [PATCH 1/4] Fix service DI bug --- src/DependencyInjection/handlers.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DependencyInjection/handlers.xml b/src/DependencyInjection/handlers.xml index 088527dc2..8146a2a87 100644 --- a/src/DependencyInjection/handlers.xml +++ b/src/DependencyInjection/handlers.xml @@ -9,7 +9,7 @@ - + From bb1112d2b43efdfed8969b2b2b3488af748a401c Mon Sep 17 00:00:00 2001 From: Fabian Boettcher Date: Tue, 4 Feb 2020 16:29:56 +0100 Subject: [PATCH 2/4] Correct status translations --- src/Resources/config/settings.xml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/Resources/config/settings.xml b/src/Resources/config/settings.xml index 4bb8f58d8..6a524b38c 100644 --- a/src/Resources/config/settings.xml +++ b/src/Resources/config/settings.xml @@ -52,49 +52,49 @@ paymentStatusAppointed - + paymentStatusCapture - + paymentStatusPaid - + paymentStatusUnderpaid - + paymentStatusCancelation - + paymentStatusRefund - + paymentStatusDebit - + paymentStatusReminder - + @@ -112,19 +112,19 @@ paymentStatusTransfer - + paymentStatusInvoice - + paymentStatusFailed - + From f3cbb14cc1e15df7562e0d7533d05e60a6a94f92 Mon Sep 17 00:00:00 2001 From: Fabian Boettcher Date: Wed, 5 Feb 2020 15:38:09 +0100 Subject: [PATCH 3/4] Remove sequence number check for refunds --- src/Payone/Request/Refund/RefundRequest.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Payone/Request/Refund/RefundRequest.php b/src/Payone/Request/Refund/RefundRequest.php index ecfac50b3..86a98bbc4 100644 --- a/src/Payone/Request/Refund/RefundRequest.php +++ b/src/Payone/Request/Refund/RefundRequest.php @@ -36,10 +36,6 @@ public function getRequestParameters( throw new InvalidOrderException($order->getId()); } - if ($customFields[CustomFieldInstaller::SEQUENCE_NUMBER] < 1) { - throw new InvalidOrderException($order->getId()); - } - $currency = $this->getOrderCurrency($order, $context); return [ From 347ae2db5e192281790d80578bc0e9f746d27caa Mon Sep 17 00:00:00 2001 From: Fabian Boettcher Date: Wed, 5 Feb 2020 16:14:32 +0100 Subject: [PATCH 4/4] Fix logic bug in refund sequence number check --- src/Payone/Request/Refund/RefundRequest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Payone/Request/Refund/RefundRequest.php b/src/Payone/Request/Refund/RefundRequest.php index 86a98bbc4..2ebb8a3cb 100644 --- a/src/Payone/Request/Refund/RefundRequest.php +++ b/src/Payone/Request/Refund/RefundRequest.php @@ -32,7 +32,7 @@ public function getRequestParameters( throw new InvalidOrderException($order->getId()); } - if (empty($customFields[CustomFieldInstaller::SEQUENCE_NUMBER])) { + if (!isset($customFields[CustomFieldInstaller::SEQUENCE_NUMBER])) { throw new InvalidOrderException($order->getId()); }