Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MOTD follow server priorities #782

Open
Carson365 opened this issue Nov 16, 2022 · 1 comment
Open

Make MOTD follow server priorities #782

Carson365 opened this issue Nov 16, 2022 · 1 comment

Comments

@Carson365
Copy link

As it is implemented currently, the MOTD ignores the settings for server fallbacks and defaults.
Ideally, the following changes to the MOTD behavior should be made for continuity with server fallback behavior:

priorities:
  - First
  - Second
servers:
  First:
    motd: 'First Server!'
    address: localhost:25564
    restricted: false
  Second:
    motd: 'Second Server!'
    address: localhost:25566
    restricted: false

if 'First' is offline the player will be connected to 'Second', so the MOTD for 'Second' should be displayed.
if all servers are offline, the player should see the MOTD of the Waterfall server.

This is in-line with the fallback behavior of the servers themselves, so it should be expected that the MOTDs would behave this way as well.

Since this behavior may not be desirable for all server owners, I suggest either tying it to the force_default_server setting since it already affects what MOTD is shown, or adding an additional setting to accomodate the change.

@xism4
Copy link
Contributor

xism4 commented Nov 17, 2022

This seems to me to hinder the internal ping system that Waterfall has. Making saturating the system much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants