Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support macosx #3

Open
oodler577 opened this issue Apr 20, 2021 · 8 comments
Open

support macosx #3

oodler577 opened this issue Apr 20, 2021 · 8 comments

Comments

@oodler577
Copy link
Collaborator

clang presents itself as gcc and even claims to support -fopenmp, but fails on the only MacOS X platform I currently have access to.

gcc installed via brew works (it's in /usr/local/bin) but it's actually gcc.

some links, will need to add more
microsoft/LightGBM#3
https://clang-omp.github.io/
@oodler577
Copy link
Collaborator Author

fyi, @mohawk2

@oodler577
Copy link
Collaborator Author

fwiw, here is the perl5 ci YAML: https://github.com/Perl/perl5/blob/blead/.github/workflows/testsuite.yml

mohawk2 pushed a commit that referenced this issue Apr 20, 2021
@oodler577 @mohawk2
Added initial support for gcc's gomp implementation.
7ff97cc 
  cflags   -> -fopenmp
  ldflags  -> -fopenmp

Makefile.PL also uses Devel::CheckLib to verify we're
in a sane gcc environment when ccname == 'gcc'.

Commit is a squash of one or more attempts of the following:

Attempt #1 to address failing gh "checks" by adding dep PMs to Makefile.PL
Attempt #2 to addressed CI
Attempt #3 to address code review
@zmughal
Copy link
Member

zmughal commented Apr 21, 2021

Adding some other tools' OpenMP compiler detection configs for comparison:

@oodler577
Copy link
Collaborator Author

thank you @zmughal !

@kiwiroy
Copy link
Collaborator

kiwiroy commented Oct 15, 2021

For CMake -DOpenMP_EXE_LINKER_FLAGS= has also been used in the past https://stackoverflow.com/a/12404666/7456461

@oodler577
Copy link
Collaborator Author

oodler577 commented Feb 25, 2022 •
edited
Loading

@kiwiroy - mind evaluating how close this is to being "done"? I think you made things work on MacOS iirc? I'm fine closing this issue on account of that, and if necessary creating a more specific one if needed.

@mohawk2
Copy link
Member

mohawk2 commented May 15, 2022

This appears to have been fixed in #11 in Oct 2021?

@kiwiroy
Copy link
Collaborator

kiwiroy commented May 15, 2022

I believe this should be closed. CI runs are successfully building on macOS. Any other reports can be made into new issues for this platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zmughal @kiwiroy @mohawk2 @oodler577