Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESTDIR in environment will be ignored if DESTDIR defined in Makefile #408

Open
djerius opened this issue Mar 4, 2024 · 0 comments
Open

Comments

@djerius
Copy link

djerius commented Mar 4, 2024

Howdy,

The value of a Makefile variable is decided by whichever of these definitions comes first:

  1. on command line
  2. in Makefile
  3. in environment

Alien::Build uses approach 3 to define DESTDIR, but upstream packages can break this if they define DESTDIR in the Makefile (if only to define it as empty). For example, the CFITSIO library maintainers recently changed the Makefile to define DESTDIR as empty, which broke Alien::Build's installation to blib, as instead it installed it directly to the final destination.

I'm not sure why upstream CFITSIO made this change, but to be safe, Alien::Build should specify DESTDIR on the command line.

Cheers,
Diab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant