Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texture prefetch memory leak (?) #32

Closed
Areteic opened this issue Oct 15, 2016 · 0 comments · May be fixed by #34
Closed

Texture prefetch memory leak (?) #32

Areteic opened this issue Oct 15, 2016 · 0 comments · May be fixed by #34

Comments

@Areteic
Copy link

Areteic commented Oct 15, 2016

With enableTexturePrefetch set to 1 custom textures are loaded into memory each time after switching windowed/fullscreen modes and/or alt-tabbing from fullscreen. This results in exceeding accessible memory and crash.
@Areteic Areteic changed the title Texture prefecth memroy leak (?) Texture prefetch memory leak (?) Oct 15, 2016
niligulmohar added a commit to niligulmohar/dsfix that referenced this issue Dec 27, 2016
@niligulmohar
Only prefetch texture overrides on first init
b82e721 
If texture override and texture prefetch was enabled, all overridden
textures would be loaded again every time the D3D device was reset, for
example when re-entering fullscreen mode again after alt-tabbing away from
DS. The already loaded textures would not be freed, leading to a
significant memory leak.

This change makes prefetching happen only on the first init, and should
fix PeterTh#32.
@niligulmohar niligulmohar mentioned this issue Dec 27, 2016
Open
This was referenced Dec 28, 2016
Merged
Merged
Merged
Merged
@Areteic Areteic mentioned this issue Jan 30, 2017
Merged
@Areteic Areteic closed this as completed Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only prefetch texture overrides on first init niligulmohar/dsfix
1 participant
@Areteic