Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCE] Add address field to Account model, & other multi-chain updates (not urgent) #49

Open
lachlanglen opened this issue Jul 18, 2024 · 0 comments
Labels
enhancement small enhancement / improvement from existing feature

Comments

@lachlanglen
Copy link
Contributor

lachlanglen commented Jul 18, 2024

Summary

As we move to support multi-chain, we will need to make two adjustments to the Account model.

These are not urgent, especially since NEAR and Stellar addresses are not compatible, but should be done before multiple EVM chains are supported.

  1. Store account address in Account.address instead of Account.id PK (this is because the same address may exist on multiple chains
  2. Use AutoField for Account.id PK instead of CharField
  3. Add unique_together constraint for Account.chain & Account.address to ensure that only one Account record exists per address per chain

This will require careful review and local testing before deploying & migrating dev/prod data.

Motivation

[More detailed explanation of the motivation for the enhancement, including any benefits it would provide]

Description

[Detailed description of the enhancement, including how it would work and any design considerations]

Alternatives

[Discussion of any alternative solutions that were considered and why the proposed solution is preferred]

Risks

[Identification and mitigation of any potential risks associated with the enhancement]

Acceptance Criteria

[List of criteria that must be met for the enhancement to be considered accepted]

Additional Information

[Any other relevant information, such as links to related issues or pull requests]

@lachlanglen lachlanglen added the enhancement small enhancement / improvement from existing feature label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement small enhancement / improvement from existing feature
Projects
None yet
Development

No branches or pull requests

1 participant