feat: Add confirm dialogs when toggling dangerous settings #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
TheAabedKhan
added
the
ReVanced Manager Compose
Axelen123
requested changes
Jul 20, 2024
app/src/main/java/app/revanced/manager/ui/component/settings/BooleanItem.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/manager/ui/component/settings/BooleanItem.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/manager/ui/component/settings/BooleanItem.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/manager/ui/component/SafeguardConfirmationDialog.kt
Outdated
Show resolved
Hide resolved
Axelen123
requested changes
Jul 20, 2024
app/src/main/java/app/revanced/manager/ui/component/settings/SafeguardBooleanItem.kt
Outdated
Show resolved
Hide resolved
…afeguardBooleanItem.kt Co-authored-by: Ax333l <[email protected]>
Axelen123
approved these changes
Jul 20, 2024
validcube
requested changes
Jul 21, 2024
There was a problem hiding this comment.
🔥 The dialog's title & description for safeguard must tell the user what the feature does and the consequences of enabling/disabling it.
- (consequences): https://m3.material.io/foundations/content-design/style-guide/ux-writing-best-practices#d7f04666-89f8-4795-a563-16d060b5ccf2
- (not really important that much, title): https://m3.material.io/components/dialogs/guidelines#0cff8b6b-d4f3-4442-8194-31212f5d1a12
Additionally, this isn't very clear to the user,
"Enforce selection of the suggested app version"
- Yes (Toggle the preference - which is on by default)
- No (Dismiss the dialog)
I assume you already knew that, so this is just a red flag check to tell maintainer to not accidentally merge.
|
Are there strings in flutter manager that could be used for this? |
We have these two in flutter {
"enablePatchesSelectionWarningText": "Changing the selection of patches may cause unexpected issues.\n\nEnable anyways?",
"requireSuggestedAppVersionDialogText": "Selecting an app that is not the suggested version may cause unexpected issues.\n\nDo you want to proceed anyways?"
} |
|
I guess those strings can be reused unless there is a better alternative |
4 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Strings need to be set