-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong softcore users count in Achievement Distribution graph #2399
Comments
This seems to be an issue with how the achievement distribution query is pulling the counts for unique Softcore vs. unique Hardcore unlocks. Like mentioned above, when pulling Softcore counts, the current query pulls "total unlocks" instead of actual softcore unlocks. Just a POC, but upon initial testing slightly tweaking the SQL, like the example below, should fix it:
|
You're right, there was a bit of a discrepancy that I was able to fix. Here's how it's currently displayed: In this case we have 5 players. 1 with 2 softcore/2 hardcore, 1 with 2 softcore, 1 with 3 softcore, and 2 with 4 hardcore. The player with a divide of hardcore and softcore unlocks is represented in the first bar (as well as the player with 2 softcore). It reads: Earned 2 Hardcore Achievements (1 player) At this point, I don't believe the "unstacked" bar graph is the direction RA wants to go, but hopefully this change will help give a better representation of the hardcore vs. softcore distribution. |
All right, although I find weird to have the player with 2 softcore / 2 hardcore being "added" with himself in the 2nd column. It turns out to be harder to represent that data that I would have thought intuitively... |
Yeah, it's a tough one. The way I interpret this is distribution of softcore vs. hardcore unlock counts in specific ranges, not necessarily total unlocks for a player. If a player unlocked all achievements for a game that had 10 achievements, but completed 8 in hardcore and 2 in softcore, they would be represented in the 8 unlocks column (hardcore) and 2 unlocks column (softcore). |
Describe the bug
In the Achievement Distribution graph on a game's page, the bars give the hardcore players count in yellow and the softcore players count in gray for each possible number of achievements (or interval).
It works as long as there are only pure hardcore and pure softcore players, but the softcore user count is wrong if there is at least one player with unlocks in both modes.
To Reproduce
As this behavior is conditioned by changing data, it's possible my example becomes obsolete, but it shouldn't happen too soon.
Expected behavior
Either real softcore players counts, or (better in my opinion) switching the second bar to "Total players" (or a better wording).
Screenshots
Additional context
The data returned by the DB query is the number of hardcore players and the total number of players for each number of achievements. The code in
RAWeb/app/Helpers/render/game.php
Line 354 in b0ce383
But a player who has mixed unlocks doesn't necessarily count in the same bucket for hardcore and total, so you can't remove them from one to get a complement of the other (I know it's not very clear, sorry).
Generally speaking, we can't determine the number of softcore players with the data returned by the DB query (I can give a simple example with 3 players and 2 achievements where there can be 2 possible situations leading to the same query result).
Event if the DB result was changed, hardcore players and softcore players should not be drawn the way they are in my opinion, as their addition doesn't mean anything when there are players with mixed unlocks (imagine a player with 2 unlocks in hardcore and 2 unlocks in softcore). Which is why I suggest to change the label and number shown, to reflect exactly what is returned by the query: hardcore and total.
The text was updated successfully, but these errors were encountered: