Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum thread link for the New Game Page Requests in both Forum Activity and Recent Posts brings up a blank page #2571

Open
Soulsderfuchs opened this issue Jul 23, 2024 · 3 comments
Labels
area/back-end kind/bug Something isn't working

Comments

@Soulsderfuchs
Copy link

Describe the bug
Clicking the the forum link for New Game Page Requests in particular brings you to an empty page instead of the forum itself. perhaps this has to be with the high number of pages the thread has but this is speculation.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Recent Posts
  2. Click on New Game Page Requests forum link
  3. See error

Expected behavior
Bring up the correct forum page

Screenshots

chrome_F03nIBom4H
chrome_pwCTTv4Pco

@wescopeland
Copy link
Member

I can't seem to reproduce this issue: https://retroachievements.org/viewtopic.php?t=13871&o=3285

Do you have an exact URL you can share that surfaces the issue?

@wescopeland wescopeland added help wanted Extra attention is needed status/blocked This issue implies changes that have unmet requirements labels Jul 23, 2024
@Soulsderfuchs
Copy link
Author

https://retroachievements.org/viewtopic.php?t=13871&c=231498#231498 seems it loads now since it has two new posts but it isnt redirecting to the actual comment which is Gravuano post in the previos page, if those two new posts werent there it would be empty like in the screenshot. This is not the first time I have caught this but it is very inconsistent.

@wescopeland wescopeland added area/back-end and removed help wanted Extra attention is needed status/blocked This issue implies changes that have unmet requirements labels Jul 23, 2024
@wescopeland
Copy link
Member

wescopeland commented Jul 23, 2024

Confirmed:

SELECT 
    u.ID AS user_id,
    u.User AS username,
    u.Permissions,
    u.banned_at
FROM 
    ForumTopicComment ftc
JOIN 
    UserAccounts u ON ftc.author_id = u.ID
WHERE 
    ftc.ForumTopicID = 13871
    AND (u.Permissions < 0 OR u.banned_at IS NOT NULL)
GROUP BY 
    u.ID;

This returns 2 results - the shift is from two banned user posts which are invisible to most users. The back-end should be ignoring these for non-mods though.

@wescopeland wescopeland added the kind/bug Something isn't working label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/back-end kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants