Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCS Saw-Tooth Behavior on Pseudo-push #67

Open
MatthewChristoff opened this issue Apr 19, 2021 · 2 comments
Open

SCS Saw-Tooth Behavior on Pseudo-push #67

MatthewChristoff opened this issue Apr 19, 2021 · 2 comments

Comments

@MatthewChristoff
Copy link
Contributor

We've noticed some strange behavior for the pseudo-push operation on our performance tests. The code for this test is located here.

On multiple tests we've seen some seemingly random patterns in the times for this operation despite averaging a hundred iterations. Further, these patterns are not consistent between runs.

Sparse

Dense

At first, an idea was that this is from some natural hardware variation because these operations took on the order of 10^-2 seconds. We attempted to increase the time of pseudo-push by adding an internal for loop, but the same issues were seen then.

@MatthewChristoff
Copy link
Contributor Author

@diamog Do you have any ideas about why this could be / what we should do from here?

@cwsmith
Copy link
Contributor

cwsmith commented Apr 19, 2021

@diamog and I discussed this and have a few ideas. In SCS with full sorting enabled the array of mesh element data is not in the same order as the rows of the SCS.

Kokkos::View<double*> parentElmData("parentElmData", ptcls->nElems());

For CabM and CSR the mesh element data is in the same order as the 'rows' in the structure. We are wondering if this ordering difference could be causing the jagged SCS performance. Towards this we can try the following:

  • run SCS without sorting, or
  • sort the element data array in descending order of particle density to match the SCS row ordering.

If these tests show no significant improvement, we may be seeing an SCS sensitivity to the particle distribution variation. To check to see if this is the case we could run SCS pseudo push over several different instances of a Gaussian distribution with the same average particle density per element and total number of elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants