Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product] When hiding/removing the quantity selector block, variant switch is broken #3512

Open
ludoboludo opened this issue Jun 10, 2024 · 0 comments
Labels
Category: Bug Something isn't working

Comments

@ludoboludo
Copy link
Contributor

Describe the current behavior

If you hide the quantity selector block on the main product page or feat. prod section, the variant switch won't happen and error out because it's not able to run some logic as it's assuming that it should find a quantity selector input. p

Describe the expected behavior

Whether it's hidden or not, the form should work and let you add to cart.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 14
  • Chrome Version 108.0.5359.124
  • macOS Version 13.1

Possible solution

Early return in updateQuantityRyles(sectionId, html){}.

if (!this.quantityInput) return;

Additional context/screenshots

Recording

@ludoboludo ludoboludo added the Category: Bug Something isn't working label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant