You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currency converter app doesn't work with the new feature "Quick Order List." With this new feature, the money format gets an append of /ea, which breaks the format and makes their script not work anymore. The “/ea” part is actually in the Locale files from Shopify for Quick Order List. This appears even in the OS 2.0 Editor Preview when adding this component.
Describe alternatives you've considered
This is part of the code from Quick Order List, the “t” filter means it’s using a localized string. On the app developers side, they tried removing the “/ea” from the locale file helps with getting rid of that part, however the HTML will still appear.
Further investigating the issue, initially believing it only occurred when the money format was altered to €{{amount}} (the format required by their Currency Converter app). However, this assumption proved incorrect. They conducted tests by reverting the currency formatting to its default values (just ${{amount}}), and found that the /ea issue persisted. This confirms that there is a fundamental issue with the Quick Orders List element that needs to be addressed across all themes utilizing it, confirming that the problem does not originate from the Vitals app.
The text was updated successfully, but these errors were encountered:
Describe the enhancement you'd like
Currency converter app doesn't work with the new feature "Quick Order List." With this new feature, the money format gets an append of /ea, which breaks the format and makes their script not work anymore. The “/ea” part is actually in the Locale files from Shopify for Quick Order List. This appears even in the OS 2.0 Editor Preview when adding this component.
Describe alternatives you've considered
This is part of the code from Quick Order List, the “t” filter means it’s using a localized string. On the app developers side, they tried removing the “/ea” from the locale file helps with getting rid of that part, however the HTML will still appear.
The team believes that to fix this, “each” translation key needs to be renamed to “each_html”, and all its usages in the liquid code also changed from “each” to “each_html”, as described here: https://shopify.dev/docs/storefronts/themes/architecture/locales/storefront-locale-files#prevent-translations-from-being-escaped.
Additional context/screenshots
Further investigating the issue, initially believing it only occurred when the money format was altered to €{{amount}} (the format required by their Currency Converter app). However, this assumption proved incorrect. They conducted tests by reverting the currency formatting to its default values (just ${{amount}}), and found that the /ea issue persisted. This confirms that there is a fundamental issue with the Quick Orders List element that needs to be addressed across all themes utilizing it, confirming that the problem does not originate from the Vitals app.
The text was updated successfully, but these errors were encountered: