Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Order List enhancement| Renaming “each” translation key to “each_html”, and all its usages in the liquid code. #3552

Open
dtaruc opened this issue Jul 5, 2024 · 0 comments

Comments

@dtaruc
Copy link

dtaruc commented Jul 5, 2024

Describe the enhancement you'd like

Currency converter app doesn't work with the new feature "Quick Order List." With this new feature, the money format gets an append of /ea, which breaks the format and makes their script not work anymore. The “/ea” part is actually in the Locale files from Shopify for Quick Order List. This appears even in the OS 2.0 Editor Preview when adding this component.

Describe alternatives you've considered

This is part of the code from Quick Order List, the “t” filter means it’s using a localized string. On the app developers side, they tried removing the “/ea” from the locale file helps with getting rid of that part, however the HTML will still appear.

The team believes that to fix this, “each” translation key needs to be renamed to “each_html”, and all its usages in the liquid code also changed from “each” to “each_html”, as described here: https://shopify.dev/docs/storefronts/themes/architecture/locales/storefront-locale-files#prevent-translations-from-being-escaped.

Additional context/screenshots

Further investigating the issue, initially believing it only occurred when the money format was altered to €{{amount}} (the format required by their Currency Converter app). However, this assumption proved incorrect. They conducted tests by reverting the currency formatting to its default values (just ${{amount}}), and found that the /ea issue persisted. This confirms that there is a fundamental issue with the Quick Orders List element that needs to be addressed across all themes utilizing it, confirming that the problem does not originate from the Vitals app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant