Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tecture Pack inconsistency #2201

Open
kada49 opened this issue Mar 3, 2024 · 5 comments
Open

Tecture Pack inconsistency #2201

kada49 opened this issue Mar 3, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@kada49
Copy link

kada49 commented Mar 3, 2024

Describe the bug
Rift collections have custom tp icons even with just vanilla tp enabled.

Profile/Location
https://sky.shiiyu.moe/stats/kada49/Raspberry#Collections

Expected behavior
SHow player heads like in the boss collections in the category below.

Screenshots
Screenshot from 2024-03-03 20-39-47
WhatsApp Image 2024-03-03 at 20 49 14

Desktop (please complete the following information):

  • OS: Fedora 39 on Linux 6.7.6
  • Browser: Mozilla Firefox
  • Version 123.0

Smartphone (please complete the following information):

  • Device: Samsung Galaxy A52 4G (SM-A525F)
  • OS: Android 13, One UI 5.1
  • Browser: Samsung Internet
  • Version: 24.0.3.4
@kada49 kada49 added the bug Something isn't working label Mar 3, 2024
Copy link

github-actions bot commented Mar 3, 2024

This looks like your first issue on SkyCrypt!
Thank you for bringing this issue to our attention.
Expect a developer to comment within the first 3-5 business days of issue submission.

@TheTrueShaman
Copy link
Contributor

I can confirm that this issue also occurs on desktop. The issue is also present for the Magmafish, Chili Pepper, Sulphur, Hard Stone and Gemstone collections. I will look further into this issue to see if I can solve it.

@kada49
Copy link
Author

kada49 commented Mar 12, 2024

I also found that the mithril collection has the same issue

@TheTrueShaman
Copy link
Contributor

I have just identified the source of the issue. The issue stems from the file following file: src/scripts/update-collections.js, more specifically on line 22. This code automatically takes the ID of item (from API), and adds that as the texture of the item. I'll see if I can fix this behavior at a later time, unless you or someone else is willing to resolve this issue soon.

@TheTrueShaman
Copy link
Contributor

Turns out, I have no idea how to test changes with texture packs (when I launch development servers it has no working textures), so I can't really help with this, at least not with the knowledge I have right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants