Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website shows deprecated documentation #142

Open
jhlegarreta opened this issue Aug 3, 2023 · 5 comments · May be fixed by #215
Open

Website shows deprecated documentation #142

jhlegarreta opened this issue Aug 3, 2023 · 5 comments · May be fixed by #215

Comments

@jhlegarreta
Copy link
Contributor

jhlegarreta commented Aug 3, 2023 •
edited
Loading

The WMA website is displaying a deprecated version of the README instructions. The website is being built from the gh-pages branch, https://github.com/SlicerDMRI/whitematteranalysis/tree/gh-pages, and the HEAD of this branch points to a 2016 commit: d1133e8.

The gh-pages branch should be updated to match the instructions in the master README.md file, which have been updated several times since.

I tend to read the README file, but anyone out there reading the installation instructions on the website will be reading to deprecated instructions.

Also, the information in the README, index.html and params.json files in the gh-pages branch is duplicated. Going forward, maybe it would be best to have a single version that can be rendered directly. Maybe readthedocs can be used for this.
@jhlegarreta
Copy link
Contributor Author

@zhangfanmark @pieper Have just realized about this. I cannot find where the custom domain is being specified within this repository (it is not in Settings, Pages, Custom domain). I'm wondering whether the rendered page domain is being specified at some of the forks of the SlicerDMRI community folks. Thanks.

@pieper
Copy link
Contributor

pieper commented Aug 3, 2023

It was being served from the gh-pages branch.
image

I've just switched ti to serve from master so there should be an update in a few minutes.

@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Aug 4, 2023 •
edited
Loading

It was being served from the gh-pages branch.

That I had seen, but there is no "Custom domain", right?

I've just switched ti to serve from master so there should be an update in a few minutes.

Serving from gh-pages was OK, as the branch has some JS code that was applying the style. The page has no style now, no header, no footer

IMO we should keep serving from gh-pagesand in the mid-term maybe switch to something simpler, e.g readthedocs, in line with Slicer, and easier to maintain across all repositories.

@pieper
Copy link
Contributor

pieper commented Aug 4, 2023

If you can migrate to readthedocs and serve the content from the master branch that would be great. Or migrate the style code into the master branch so that there's only one branch to keep up to date. Serving out of date content makes no sense and trying to maintain two branches doesn't sound sustainable for this project.

@jhlegarreta
Copy link
Contributor Author

This will go to my backlog until we figure out the best way to minimize maintenance, having a consistent way to serve documentation across SlicerDMRI org repositories. Thanks Steve.

@jhlegarreta jhlegarreta changed the title Website shows to deprecated documentation Website shows deprecated documentation Dec 1, 2023
@jhlegarreta jhlegarreta linked a pull request Dec 1, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Transfer documentation in README to proper Markdown doc files jhlegarreta/whitematteranalysis
2 participants
@pieper @jhlegarreta