Ancient Altar will rename potion items

[xMikux]

❗ Checklist

• I am using the official english version of Slimefun and did not modify the jar.
• I am using an up to date "DEV" (not "RC") version of Slimefun.
• I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
• I searched for similar open issues and could not find an existing bug report on this.

📍 Description

Ancient Altar will rename the potion, splash potion, lingering potion and potion arrow name.

📑 Reproduction Steps

1. Place potion type item to Ancient Altar
2. Take it down
3. See it will show include [] item name

💡 Expected Behavior

Don't rename the any potion type items, and take back will show normal vanilla item name.

📷 Screenshots / Videos

Before put on the Ancient Altar

After take down from the Ancient Altar

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.18.x

⭐ Slimefun version

🧭 Other plugins

No response

[Creependerman]

I think it's maybe because of NBT. The screenshot show the NBT was changed by Ancient Altar.

[Creependerman]

Yes, my guess is real. I saw though the AncientPedestal.java, when you place item, the Ancient Altar turn the item into entity. Then you take it down, Ancient Altar turn the entity into item. So the item will be change.

[Creependerman]

I think the better way is make the Ancient Altar memory the item.

[JustAHuman-xD]

I can probably throw a fix for this into my existing PR. I'll do that tomorrow (today? It's three thirty am) 👍

[JustAHuman-xD]

Does this only happen for potions?

[JustAHuman-xD]

Found the cause, should be simple enough to fix