Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Validate checks from commons-lang with Preconditions checks from Guava #3586

Open
TheBusyBiscuit opened this issue Jun 11, 2022 · 1 comment
Open

Replace Validate checks from commons-lang with Preconditions checks from Guava #3586

TheBusyBiscuit opened this issue Jun 11, 2022 · 1 comment
Labels
good first issue This is an Issue that may be easy to fix if you are a beginner 🔧 Technical Thread This Issue is a technical Thread where developers can discuss technical changes to Slimefun.

Comments

@TheBusyBiscuit
Copy link
Member

See #3585 for context.

In MC 1.19 Spigot has removed commons-lang from its dependencies.
We really shouldn't be shading this library just for this one feature and instead switch to what Spigot uses.

So any Validate.notNull(x, msg) will become Preconditions.checkNotNull(x, msg) and any Validate.isTrue(x, msg) shall become Preconditions.checkArgument(x, msg).
It would be really helpful if somebody could make a pull request for this and remove commons-lang from our pom.xml.
@TheBusyBiscuit TheBusyBiscuit added good first issue This is an Issue that may be easy to fix if you are a beginner 🔧 Technical Thread This Issue is a technical Thread where developers can discuss technical changes to Slimefun. labels Jun 11, 2022
@TheBusyBot TheBusyBot added the invalid This Issue or Pull Request is invalid. label Jun 11, 2022
@Slimefun Slimefun deleted a comment from TheBusyBot Jun 11, 2022
@TheBusyBiscuit TheBusyBiscuit removed the invalid This Issue or Pull Request is invalid. label Jun 11, 2022
@ybw0014 ybw0014 mentioned this issue Jun 11, 2022
Closed
6 tasks
@Haarolean
Copy link

It seems like it's blocked by Slimefun/dough#184 via #3589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This is an Issue that may be easy to fix if you are a beginner 🔧 Technical Thread This Issue is a technical Thread where developers can discuss technical changes to Slimefun.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Validate checks ybw0014/Slimefun4
3 participants
@Haarolean @TheBusyBiscuit @TheBusyBot