Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jitpack): bump jdk version to 21 #4243

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented Sep 15, 2024

Description

This PR allows jitpack to build Slimefun with Java 21.

Proposed changes

In jitpack.yml:

  • Bumped the JDK version to 21
  • Install the latest maven (ig)

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Sep 15, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

@ybw0014 ybw0014 marked this pull request as draft September 15, 2024 23:17
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 24c04d4

https://preview-builds.walshy.dev/download/Slimefun/4243/24c04d46

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@ybw0014 ybw0014 marked this pull request as ready for review September 15, 2024 23:25
@ybw0014 ybw0014 requested a review from a team as a code owner September 15, 2024 23:25
@ybw0014
Copy link
Contributor Author

ybw0014 commented Sep 15, 2024

@WalshyDev WalshyDev merged commit e02a0f6 into Slimefun:master Sep 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants