Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the solution to simStreamJoinFork conform to the handshake standard? #16

Open
dzx-dzx opened this issue Aug 27, 2022 · 2 comments
Open

Comments

@dzx-dzx
Copy link

dzx-dzx commented Aug 27, 2022

From the Rules for Ready/Valid Handshakes:

At any time, the source interface raises and holds steady valid when data is available

But in SimStreamUtils.scala:

stream.valid #= false
    while(true){
      stream.valid.randomize()
      stream.payload.randomize()
      clockDomain.waitSampling()
    }

Which seems that...valid just asserts and deasserts randomly?

@dzx-dzx dzx-dzx changed the title Does The solution to simStreamJoinFork conform to the handshake standard? Does the solution to simStreamJoinFork conform to the handshake standard? Aug 27, 2022
@Dolu1990
Copy link
Member

simStreamJoinFork, the commented out code ?

It isn't compliant, you ar eright, the valid should stay steady.
There is a few corner case, where you have Stream element which are capable to handle / may generate not steady valid for good reasons, but that's realy not the norm :)

@Dolu1990
Copy link
Member

Hooo sorry simStreamJoinFork from SpinalWorkshop, not SpinalHDL, i was confused.

Got it now XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants