Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to Sensor from PollingSensor for SQS Sensor #90

Open
grepory opened this issue Dec 18, 2019 · 2 comments · May be fixed by #91
Open

Change to Sensor from PollingSensor for SQS Sensor #90

grepory opened this issue Dec 18, 2019 · 2 comments · May be fixed by #91

Comments

@grepory
Copy link

grepory commented Dec 18, 2019

Right now, the PollingSensor caps at 10 messages per second due to the API limit for maximum messages in a transaction and the minimum polling rate of 1 Hz.

We have modified the SQS sensor locally to be a continuously running Sensor that does its own polling loop instead of a scheduled poll as we have to handle 30+ messages per second. Would this be a welcomed upstream contribution?

@Kami
Copy link
Contributor

Kami commented Dec 18, 2019

Yeah, the contribution would be more than welcome.

For backward compatibility and similar reasons, it would probably be good to add it as a separate sensor though.

@grepory
Copy link
Author

grepory commented Dec 18, 2019

That makes sense to me. Thanks!

@grepory grepory linked a pull request Dec 18, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants