Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model/type references in other models shouldn't receive the support.class scope. #3

Open
Ultra-Instinct-05 opened this issue Mar 19, 2022 · 1 comment
Labels
bug Something isn't working syntax

Comments

@Ultra-Instinct-05
Copy link
Contributor

Description of the bug

Currently, model/type references in other models/types receive the support.class scope which is totally wrong (because they are not something that a standard library provides. Prisma Schema Language doesn't have that concept). The reason I chose it was for the coloring of model/types to be different from standard scalar types (like Int, String etc.). Ideally, it should receive something like variable.other.model.prisma based on sublimehq/Packages#1861 but variable scopes are always colorless, so it's visually straining to distinguish them.

Steps to reproduce

Refer the syntax definition.

Expected behavior

Model/type references have variable.other.model scope. We could put some steps on tweaking the color scheme to color variable.other.model the same as support.class but that's an additional wall for some.

Actual behavior

Model/type references have support.class scope.

PrismaHighlight version

1.0.2

@Ultra-Instinct-05 Ultra-Instinct-05 added bug Something isn't working syntax labels Mar 19, 2022
@Ultra-Instinct-05
Copy link
Contributor Author

On second thoughts, it might be difficult to scope it exactly as variable.other.model as in MongoDB schemas, we don't know whether it's going to be a model or a composite type,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working syntax
Development

No branches or pull requests

1 participant