-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile creates installed transformtei with potentially incorrect path #552
Comments
BTW, have to think about how to make sure that the “${PREFIX}” is expanded by the shell, not interpreted by Perl. |
Changed |
Oops. Looks like we never generated a PR for this and actually merged it with the dev branch. |
Prodding @sydb to wrap this one up--should be easy? |
No, certainly not during freeze. I am not sure what this “sydb” idiot was talking about back on 2023-04-04, but @bleekere (appropriately, IMHO) made this change to a branch which was never merged. So this change has never been tested, and looking at it, I think it might be wrong. (As alluded to earlier, one has to be very careful about whether |
@sydb I know! But you'll notice I set the next release milestone on it. I'm basically doing a sort of census of tickets that we'd marked for this milestone and making sure we don't lose track of these... So my comment on this ticket was fully intended for the 7.58 milestone! |
OK. I have ascertained the |
* Changed to in Makefile #552 * Forgot to delete no-longer needed comment :-) --------- Co-authored-by: Elli Bleeker <[email protected]>
Fix merged via #691. |
Per the comment preceding it, the “/usr” in the following line of the Makefile should read “${PREFIX}”.
This is currently line 136. See #551 for some discussion.
That said, I do not (at the moment) understand what $APPHOME vs $defaultAPPHOME is doing in the transformtei program. While this should probably be fixed either way, if we understood what was going on we might be able to skip this step entirely.
The text was updated successfully, but these errors were encountered: