Fixes #657 #682
Draft
Fixes #657 #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebeshero
requested review from
HelenaSabel and
sydb
and removed request for
HelenaSabel
|
@sydb @martinascholger @HelenaSabel I think we just lost track of this work that @joeytakeda did in May to improve the output CSS of generated ODDs. I just updated the branch and the tests are passing. (I'm not suggesting we merge it for the imminent release, but we may want to continue working on CSS for custom ODD-generated HTML on this branch, and merge for the next release?) |
|
@ebeshero: I will be partial to merging the current work as it is after the release (if @joeytakeda agrees). In principle, the current generation of ODD documentation will be superseded relatively soon so I wonder if it isn’t better to work on issues with higher priority. |
sydb
requested changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another rule to odd.css to ensure colon and space