Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace imports are invisible #330

Open
Kixiron opened this issue Jul 8, 2021 · 4 comments
Open

Trace imports are invisible #330

Kixiron opened this issue Jul 8, 2021 · 4 comments

Comments

@Kixiron
Copy link
Contributor

Kixiron commented Jul 8, 2021

No events are emitted that can be used to piece together where an imported trace came from, TraceAgents manage their data internally and .import() uses the source operator to create an entirely new source, so there's no ChannelsEvent linking the two streams nor any sort of differential event that links them.

@frankmcsherry
Copy link
Member

Just to make sure that I understand the issue, trace imports are reported (the TraceShare logging event), but not enough breadcrumbs are reported to let you link up the the imported arrangement with the location it was imported to?

@Kixiron
Copy link
Contributor Author

Kixiron commented Jul 13, 2021

Yep, precisely. TraceShare just says that an arrangement came from somewhere, but not where it actually comes from

@frankmcsherry
Copy link
Member

I think it might be the other way around. TraceAgent records the operator id it was constructed with, and on each importing event increments that. So, each import does announce where it came from, but only where it came from (not, e.g. where it was imported to). Maybe that is what you meant though.

@Kixiron
Copy link
Contributor Author

Kixiron commented Jul 13, 2021

Yes, that's my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants