Spine drop batches once logical and physical compaction frontiers are empty #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is right. Physical compaction can be allowed up through |
antiguru
changed the title
Comment on lines
485
to
490
| // If the logical frontier is empty, we are not obliged to be able to represent any time, | ||
| // since no time is in advance of `[]`. In the case, we can drop all contents. | ||
| if self.logical_frontier.is_empty() { | ||
| self.drop_batches(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is there an explainer for why the code is here, rather than in e.g. set_logical_compaction?
There was a problem hiding this comment.
Moved the code to set_logical_compaction and insert. As far as I can tell these are the only places where logical compaction is advanced, and new batches are inserted.
Once the logical compaction frontier is empty, there are no times that can be represented in a a trace, which means that we're good to drop all contents. Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
5 tasks
antiguru
changed the title
|
Closing because this approach is not correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the
physicallogical compaction frontier is empty, there are no times that can be represented in a a trace, which means that we're good to drop all contents.This fixes #398.