Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockOperator.domain_geometry().allocate() not compatible with in place calls to BlockOperator.direct #1863

Open
MargaretDuff opened this issue Jul 9, 2024 · 1 comment · May be fixed by #1644 or #1926
Open

BlockOperator.domain_geometry().allocate() not compatible with in place calls to BlockOperator.direct #1863

MargaretDuff opened this issue Jul 9, 2024 · 1 comment · May be fixed by #1644 or #1926
Assignees
@MargaretDuff
Labels
bug Something isn't working

Comments

@MargaretDuff
Copy link
Member

Description

Due to #1802, if you use out=myblockoperator.domain_geometry().allocate(0) where myblockoperator is a BlockOperator of size (1,1) then out will be a DataContainer and not a BlockDataContainer.

If you then call myblockoperator.direct(something, out=out) you get an error because you try and call getitem on the data container out.

This leads to errors when you try and run PDHG or SPDHG on partitioned data with just one batch e.g.

data = dataexample.SIMPLE_PHANTOM_2D.get(size=(10, 10))

        subsets = 1

        ig = data.geometry
        ig.voxel_size_x = 0.1
        ig.voxel_size_y = 0.1

        detectors = ig.shape[0]
        angles = np.linspace(0, np.pi, 90)
        ag = AcquisitionGeometry.create_Parallel2D().set_angles(
            angles, angle_unit='radian').set_panel(detectors, 0.1)
        # Select device
        dev = 'cpu'

        Aop = ProjectionOperator(ig, ag, dev)

        sin = Aop.direct(data)
        partitioned_data = sin.partition(subsets, 'sequential')
        A = BlockOperator(
            *[IdentityOperator(partitioned_data[i].geometry) for i in range(subsets)])
       
        # block function
        F = BlockFunction(*[L2NormSquared(b=partitioned_data[i])
                                 for i in range(subsets)])
        alpha = 0.025
        G = alpha * FGP_TV()
        
        spdhg = SPDHG(f=F, g=G, operator=A,  update_objective_interval=10)
        
        spdhg.run(7)   
        pdhg = PDHG(f=F, g=G, operator=A, update_objective_interval=10)
        
        pdhg.run(7)
@MargaretDuff MargaretDuff added the bug Something isn't working label Jul 9, 2024
@MargaretDuff MargaretDuff self-assigned this Jul 9, 2024
@MargaretDuff
Copy link
Member Author

@paskino - would appreciate your help on this one, it is a bit mind-boggling

@MargaretDuff MargaretDuff linked a pull request Jul 9, 2024 that will close this issue
Open
8 tasks
@MargaretDuff MargaretDuff linked a pull request Sep 3, 2024 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MargaretDuff MargaretDuff

Labels
bug Something isn't working
Projects
CIL work
Status: In Review
Milestone
No milestone
1 participant
@MargaretDuff