Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better pre-commit config #98

Open
DanicaSTFC opened this issue Oct 31, 2023 · 5 comments
Open

better pre-commit config #98

DanicaSTFC opened this issue Oct 31, 2023 · 5 comments
Assignees

Comments

@DanicaSTFC
Copy link
Collaborator

Pre-commit on GitHub checks the code and commits automatically part of the suggested changes. It leaves some suggestions unsolved with the red cross appearing and stopping the merge. It would be easier if we could run the checker online, receive a report from it and then decide to accept or reject the changes and fix some things manually. There are some issues, in particular, with long lines of code and alignment of # comments. The suggested edits and indentations do not look good.

I started to use the pre-commit offline in my local repository and it works well because the suggestions are not forced in a commit and I can amend them.

@lauramurgatroyd
Copy link
Member

Please can you link some examples where it does not look good?

@DanicaSTFC DanicaSTFC added the help wanted Extra attention is needed label Nov 8, 2023
@casperdcl
Copy link
Member

@DanicaSTFC

This comment was marked as off-topic.

@casperdcl casperdcl changed the title Pre-commit forces commit on partial suggestions only better pre-commit config Jan 25, 2024
@casperdcl casperdcl assigned DanicaSTFC and unassigned casperdcl Jan 25, 2024
@DanicaSTFC
Copy link
Collaborator Author

@casperdcl pointed out this is high priority for other repositories too, finalise before end of June 2024

@DanicaSTFC DanicaSTFC removed the help wanted Extra attention is needed label Jul 15, 2024
@DanicaSTFC
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants