Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP query params are not signed #215

Open
iFergal opened this issue Feb 14, 2024 · 2 comments
Open

HTTP query params are not signed #215

iFergal opened this issue Feb 14, 2024 · 2 comments

Comments

@iFergal
Copy link
Contributor

iFergal commented Feb 14, 2024

siginput should accept query params to be signed when sending a HTTP request. Right now it's just the path of the URL.

fetch and signedFetch (and any other calling functions if there are any) should then pass the query param to be signed.
@pfeairheller
Copy link
Member

I will add a link to the HTTP signature headers specification.

@pfeairheller
Copy link
Member

https://www.ietf.org/archive/id/draft-ietf-httpbis-message-signatures-19.html

@iFergal iFergal mentioned this issue Aug 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pfeairheller @iFergal