Create isBipartiteGraph.hpp #465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbaldu
reviewed
Sep 6, 2024
|
Also, can you add a couple of tests please? |
->Test for Bipartite Graph ->Test for Non-Bipartite Graph ->Test for Empty Graph ->Test for Single Node Graph ->Test for Complex Bipartite Graph
sbaldu
reviewed
Sep 6, 2024
There was a problem hiding this comment.
The tests are failing. You need to include this file in CXXGraph/include/Graph/Graph.h
sbaldu
requested changes
Sep 7, 2024
|
|
||
| CXXGraph::Graph<int> graph(edgeSet); | ||
|
|
||
| bool isBipartite = graph.isBipartite(); |
There was a problem hiding this comment.
This method doesn't exist, you didn't define it. Maybe you'd want to rename the methods in the header file.
Comment on lines
+30
to
+38
| class Graph { | ||
| public: | ||
| TopoSortResult<T> checkOddNodesCycleDir() const; | ||
|
|
||
| private: | ||
| void checkOddNodesCycleUtil(std::vector<int>& visited, | ||
| std::vector<int>& chainNo, int root, | ||
| int cycleLength, bool& isBiPartite) const; | ||
| }; |
There was a problem hiding this comment.
You can't re-declare the class here. Declare the methods in the Graph_decl.hpp file, possibly adding method descriptions like you see there, and in this file you only define them
|
Also, check that the code compiles and runs before committing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
->ISSUE REFERENCE:
#464 (comment)
->DESCRIPTION:
Implemented a header file to check if the graph is biPartite or biColourable. The algorithm has its own cycle detection algorithm which counts the number of nodes in the cycle and checks for odd nodes cycle, which determines whether the undirected graph is biPartite.
->REVIEW MEMBER
@ZigRazor