Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scope by id on main models #44

Closed
wants to merge 1 commit into from
Closed

Conversation

robbevp
Copy link
Member

@robbevp robbevp commented Apr 21, 2020

fix #39

@robbevp robbevp added the enhancement New feature or request label Apr 21, 2020
@robbevp robbevp added this to the 1.0 milestone Apr 21, 2020
@robbevp robbevp requested a review from chvp April 21, 2020 17:53
@robbevp robbevp self-assigned this Apr 21, 2020
@chvp
Copy link
Member

chvp commented Jun 6, 2020

I still feel like this is something we don't really want to do. Do you still feel strongly about this feature? If not, you can close this (and the linked issue). Otherwise, we'll talk about this in-person some more.

You could also repurpose the linked issue into something else, namely that we do need a more coherent story on synchronization issues (but I fear that there is no easy solution there).

@robbevp
Copy link
Member Author

robbevp commented Jun 6, 2020

I still feel like this is something we don't really want to do. Do you still feel strongly about this feature? If not, you can close this (and the linked issue). Otherwise, we'll talk about this in-person some more.

You could also repurpose the linked issue into something else, namely that we do need a more coherent story on synchronization issues (but I fear that there is no easy solution there).

I don't feel that strongly about it anymore - I think we found a good way to handle merges and deletions.
The synchronization will need some work/upgrades in the future, so I'll rework the issue

@robbevp robbevp closed this Jun 6, 2020
@chvp chvp deleted the Enhc/allow-filter-by-ids branch June 6, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle synchronisation of linked objects in a smarter way
2 participants