Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1389: "push:artifact" command has support for multiple git urls using acli config file but not supported in file. #1788

Closed
joshirohit100 opened this issue Sep 2, 2024 · 2 comments · Fixed by #1789
Labels
bug Something isn't working

Comments

@joshirohit100
Copy link
Contributor

joshirohit100 commented Sep 2, 2024

acli push:artifact command supports multiple git urls and as per https://github.com/acquia/cli/blob/main/src/Command/Push/PushArtifactCommand.php#L164 config can be done using acli config file (acquic-cli.yml) but looks like code for this is not supported as AcquiaCliConfig only supports one key cloud_app_uuid

https://github.com/acquia/cli/blob/main/src/Config/AcquiaCliConfig.php#L23

This is my sample acli config file -

cloud_app_uuid: APPIDHERE
push:
  artifact:
    destination_git_urls:
      - GITURL1HERE
      - GITURL2HERE
@joshirohit100 joshirohit100 added the bug Something isn't working label Sep 2, 2024
@github-actions github-actions bot changed the title "push:artifact" command has support for multiple git urls using acli config file but not supported in file. CLI-1389: "push:artifact" command has support for multiple git urls using acli config file but not supported in file. Sep 2, 2024
@joshirohit100
Copy link
Contributor Author

to fix this -

$treeBuilder
            ->getRootNode()
                ->children()
                    ->scalarNode('cloud_app_uuid')->end()
                    ->arrayNode('push')
                        ->children()
                            ->arrayNode('artifact')
                                ->children()
                                    ->arrayNode('destination_git_urls')
                                        ->scalarPrototype()->end()
                                    ->end()
                                ->end()
                            ->end()
                        ->end()
                    ->end()
                ->end();

@joshirohit100
Copy link
Contributor Author

pull request for ref - #1789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant