Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ADRs to record decisions for vNext #111

Open
kenmuse opened this issue Aug 26, 2024 · 1 comment
Open

Create ADRs to record decisions for vNext #111

kenmuse opened this issue Aug 26, 2024 · 1 comment
Milestone

Comments

@kenmuse
Copy link
Collaborator

kenmuse commented Aug 26, 2024

  1. Move away from directly supporting development outside of a dev container. Given the dependencies in v2, it doesn't make sense and adds overhead
  2. Move to using the Client ID instead of the Application ID (assuming Probot support), consistent with https://github.blog/changelog/2024-08-23-client-ids-are-now-included-in-app-api-responses/. If support is missing today, still require Client ID in the IaC for deployment to support that transition once it is supported.
  3. Validation, builds, and dev container should all use the same version of NodeJS. At the present time, builds/validation can use a newer version than what was used for development.
  4. Naming convention for images/packages will broadly be probot-security-alerts-$HOST-$TYPE, with fields removed if not appropriate:
    • probot-security-alerts-azure-functions
    • probot-security-alerts-aws-lambda
    • probot-security-alerts-server
      Tags will have our version number and, as appropriate, node$MAJOR:
    • :2.0.0-node20
    • :2.0.0-node22
  5. Running in development mode will not be supported with Azure Functions or Lambda. Only with standalone server code/image.
@kenmuse kenmuse added this to the v2.0.0 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@kenmuse and others