Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UserByIPResource to return 200 instead of 404 on nonexistent user #666

Open
lukasjuhrich opened this issue Sep 28, 2023 · 0 comments

Comments

@lukasjuhrich
Copy link
Collaborator

Since sentry (rightfully) interprets 4xx status codes as failures, we should not emit one if sipa requests a user to an IP which does not exist (which is part of normal operation). Instead, pycroft should return an empty result.

The behavior has to be adapted both in pycroft and in sipa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant