Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ament_lint_cmake doesn't display reasons for error when run through pre-commit #495

Open
bijoua29 opened this issue Jun 4, 2024 · 1 comment
Assignees
Labels
more-information-needed Further information is required

Comments

@bijoua29
Copy link

bijoua29 commented Jun 4, 2024

ament_lint_cmake doesn't display reasons for error when run through pre-commit hook. It just displays exit code of 1 like:

ament_lint_cmake.........................................................Failed

  • hook id: ament_lint_cmake
  • exit code: 1

However if I run ament_lint_cmake manually, it displays the actual errors.

@mjcarroll
Copy link
Contributor

Can you elaborate on what you are trying to do here? I don't believe that we have a recommended pre-commit hook setup.

I imagine that what you are running into is that the ament_lint_cmake utility either outputs to stdout or stderr and that the pre-commit script is expecting the output on the opposite.

@mjcarroll mjcarroll added the more-information-needed Further information is required label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

No branches or pull requests

2 participants