Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Module: Invalid imports in 1-start branch #30

Open
tgavara opened this issue Jul 5, 2023 · 1 comment
Open

App Module: Invalid imports in 1-start branch #30

tgavara opened this issue Jul 5, 2023 · 1 comment

Comments

@tgavara
Copy link

tgavara commented Jul 5, 2023

app.module.ts imports the below even when there is not 'Directives' folder in the '1-start' branch

import {AppShellRenderDirective} from "./directives/app-shell-render.directive";
import {AppShellNoRenderDirective} from "./directives/app-shell-norender.directive";
@faridhajnal
Copy link

yes i faced the very same situation. Just go ahead and remove those imports and the directives from the declarations array. If you follow the course, those directives will be created and added to the app.module.ts.
Of course this should ideally be fixed by a PR or something so that other students don't experience this issue when freshly cloning the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants