Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up apify run to move logic that is runtime dependent to ProjectAnalyzer #476

Open
vladfrangu opened this issue Feb 6, 2024 · 0 comments
Open

Clean up apify run to move logic that is runtime dependent to ProjectAnalyzer #476

vladfrangu opened this issue Feb 6, 2024 · 0 comments
Assignees
@vladfrangu
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@vladfrangu
Copy link
Member 

          This kind of code looks like something I'd expect in `ProjectAnalyzer`. Couldn't the error be thrown if no project type matches? It could mean adding project types such as `PROJECT_TYPES.UNKNOWN_PYTHON` or `UNKNOWN_JAVASCRIPT`...

Originally posted by @janbuchar in #475 (comment)
@vladfrangu vladfrangu self-assigned this Feb 6, 2024
@vladfrangu vladfrangu mentioned this issue Feb 6, 2024
Merged
@B4nan B4nan added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladfrangu vladfrangu

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@B4nan @vladfrangu